Skip to content

fix(linter): fix eslint/sort-imports allowSeparatedGroups not working with single empty line #16012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(linter): fix eslint/sort-imports allowSeparatedGroups not working with single empty line #16012

wants to merge 2 commits into from

Conversation

@xuanduc987
Copy link
Contributor

@xuanduc987 xuanduc987 commented Nov 23, 2025

This fixes #15990

@xuanduc987 xuanduc987 requested a review from camc314 as a code owner November 23, 2025 22:53
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 23, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-linter Area - Linter C-bug Category - Bug labels Nov 23, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 24, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #16012 will not alter performance

Comparing xuanduc987:push-kwqloorxyvpp (ad331ae) with main (3976e4f)

Summary

✅ 4 untouched
⏩ 41 skipped1

Footnotes

  1. 41 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

connorshea
connorshea reviewed Nov 24, 2025
View reviewed changes
crates/oxc_linter/src/rules/eslint/sort_imports.rs
"import b from 'b';
import a from 'a';",
import a from 'a';",
Copy link
Contributor

@connorshea connorshea Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this code should pass the rule even if this import has spaces in front of it. It does in ESLint: https://eslint.org/play/#eyJ0ZXh0IjoiaW1wb3J0IHsgZm9ybWF0IH0gZnJvbSBcIm94Zm10XCI7XG5cbiAgICAgICAgIGltcG9ydCB7IGRlZmluZVJ1bGUgfSBmcm9tIFwib3hsaW50XCI7XG4iLCJvcHRpb25zIjp7InJ1bGVzIjp7InNvcnQtaW1wb3J0cyI6WyJlcnJvciIseyJhbGxvd1NlcGFyYXRlZEdyb3VwcyI6dHJ1ZX1dfSwibGFuZ3VhZ2VPcHRpb25zIjp7InBhcnNlck9wdGlvbnMiOnsiZWNtYUZlYXR1cmVzIjp7fX0sImVjbWFWZXJzaW9uIjoyMDI2fX19

Copy link
Contributor Author

@xuanduc987 xuanduc987 Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the change in this test is to fail the previous implementation

Copy link
Contributor

@connorshea connorshea Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, can we include both still?

Copy link
Contributor Author

@xuanduc987 xuanduc987 Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I added a new test case instead of modifying the existing one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@connorshea connorshea connorshea left review comments

@camc314 camc314 Awaiting requested review from camc314 camc314 is a code owner

At least 0 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

A-linter Area - Linter C-bug Category - Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

linter: eslint/sort-imports/allowSeparatedGroups does not work with single empty line

2 participants

@xuanduc987 @connorshea